Skip to content

Upgrade fbcode/executorch to Python Scientific Stack 3 (#18737)#18737

Open
SS-JIA wants to merge 1 commit intopytorch:mainfrom
SS-JIA:export-D99707657
Open

Upgrade fbcode/executorch to Python Scientific Stack 3 (#18737)#18737
SS-JIA wants to merge 1 commit intopytorch:mainfrom
SS-JIA:export-D99707657

Conversation

@SS-JIA
Copy link
Copy Markdown
Contributor

@SS-JIA SS-JIA commented Apr 7, 2026 •
edited by meta-codesync bot
Loading

Summary: Pull Request resolved: #18737

Differential Revision: D99707657

@SS-JIA SS-JIA requested a review from robert-kalmar as a code owner April 7, 2026 14:34
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 7, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18737

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 1 Cancelled Job, 5 Pending, 4 Unrelated Failures

As of commit 88bfcad with merge base e638059 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Apr 7, 2026

@SS-JIA has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99707657.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@SS-JIA
Copy link
Copy Markdown
Contributor Author

SS-JIA commented Apr 7, 2026

@robert-kalmar There are efforts within Meta to upgrade to new numpy versions; it seems that some changes in the NXP backend will be needed for this. Just want to check with you guys if the changes make sense.

@meta-codesync meta-codesync bot changed the title Upgrade fbcode/executorch to Python Scientific Stack 3 Upgrade fbcode/executorch to Python Scientific Stack 3 (#18737) Apr 8, 2026
@SS-JIA SS-JIA force-pushed the export-D99707657 branch from 19d5d09 to a9c825f Compare April 8, 2026 16:51
SS-JIA pushed a commit to SS-JIA/executorch-1 that referenced this pull request Apr 8, 2026
@melicho @facebook-github-bot
Upgrade fbcode/executorch to Python Scientific Stack 3 (pytorch#18737)
a9c825f 
Summary: Pull Request resolved: pytorch#18737

Differential Revision: D99707657
@melicho @meta-codesync
Upgrade fbcode/executorch to Python Scientific Stack 3 (pytorch#18737)
88bfcad 
Summary: Pull Request resolved: pytorch#18737

Differential Revision: D99707657
@SS-JIA SS-JIA force-pushed the export-D99707657 branch from a9c825f to 88bfcad Compare April 8, 2026 16:55
@robert-kalmar
Copy link
Copy Markdown
Collaborator

robert-kalmar commented Apr 9, 2026 •
edited
Loading

@robert-kalmar There are efforts within Meta to upgrade to new numpy versions; it seems that some changes in the NXP backend will be needed for this. Just want to check with you guys if the changes make sense.

@SS-JIA, understand. The changes are legit. It is only Meta internal upgrade, or OSS ExecuTorch too? This PR contains just the update for the API used to NUMPY, but not the numpy version - https://github.com/pytorch/executorch/blob/main/pyproject.toml . Is the intention is allow both numpy 2.x and 3x or the update is just split into multiple PRs?

FYI, such a PR was already opened by @rascani #16714 some time ago, but not merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

@robert-kalmar robert-kalmar robert-kalmar approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SS-JIA @robert-kalmar @digantdesai @melicho